Help/input wanted on a couple of updates

Deimos
Mon, 22 Oct 2018 20:17:59 +0000

Nothing very major has changed yet, but I'm working on adding a couple of open-source contributions to the site and could use some help and input related to them:

Theme system rework

First, I've just deployed a rework of the "theme system" (for the display themes that you can select in your settings) that @Bauke has been brave enough to work on. As some of you know, the site originally only had two themes - Solarized Light and Solarized Dark. Because of this, the theme system was built around those themes and meant that the Solarized colors had to be used in all other themes as well. This is why, for example, the new default theme (with the white background) still uses Solarized colors for links/alerts/etc., even though the contrast and appearance of some of them isn't very good on white.

This rework will allow every theme to have completely custom colors (as well as other possibilities), but the first stage was just deploying a refactor to convert the existing themes to this new system. If you've ever tried to refactor CSS, you know that it's not much fun and there are a lot of subtle things that can go wrong. So as of right now: nothing should look different yet, and if you notice any issues with colors or other appearance changes, please post here to let me know.

This is mostly just to make sure that nothing's been messed up during the transition to the new system, and once it seems safe we can start making more interesting changes like adjusting colors, adding more themes that diverge from that Solarized base, and so on. But for now, we're just looking for issues in the existing themes to make sure everything survived the transition intact.

Saving/bookmarking/favoriting/etc. terminology

@what has also been working on a contribution that will add the ability to save/bookmark topics and comments. It's close to being ready to deploy, but I thought I'd ask for some input about what term to use for the function before it goes live, since it will be more hassle to change it afterwards if necessary.

"Save" has the benefit of being short and also used on other sites like reddit, Facebook, and some others. I think it's slightly misleading though, because you're not really saving the post, just a link to it. If the author deletes it, you won't have it saved.

"Bookmark" is probably more correct, and used by some sites including Twitter. However, it's longer and may be confusing to some people if they think it's related to browser bookmarks.

Any preference on either of those, or are there other options (like "favorite") that might be best?

Comments URL: https://tildes.net/~tildes.official/7rd/help_input_wanted_on_a_couple_of_updates

Votes: 57

Comments: 57