7 votes

Tag formatting inconsistencies

I've been noticing a couple of weird formatting issues with tags on topics. For some posts, the first tag is shown before the metadata, then the rest of the tags are on a new line below. This isn't always the case, and so far I can't find any rhyme or reason for whether it does or not. It's not like some CSS float issue or anything, it's actually creating two <ul>'s. — example

The second issue I've noticed is sometimes the dangling part of a letter like lowercase "g" will be cut off by the footer. It seems like this is caused by .label {line-height: 1.2;}, but it's also inconsistent, and I haven't figured out why. In this example the "g" in "climate change" is not affected.

Maybe it's just me, I dunno. Firefox 70 on linux. I'd create a gitlab issue, except I am very lazy.

6 comments

  1. [3]
    Deimos
    (edited )
    Link
    I increased the line-height on the tags a little now, which I think should help with the descenders getting cut off. Not entirely sure what was causing that to happen, but it seems like some part...

    I increased the line-height on the tags a little now, which I think should help with the descenders getting cut off. Not entirely sure what was causing that to happen, but it seems like some part of the responsive changes for smaller screen sizes. For me, it was happening around the point where the sidebar starts hiding, and there are quite a few adjustments that happen around there.

    As for the two separated lists of tags, yeah, that's a little weird. It only happens if you have the user setting to always show all tags on, which is non-default and very rare overall. You might have had it enabled for you automatically when I made the layout change at the start of October to start hiding most tags on the listings, since I think you had tagging permissions and I enabled it for everyone that had them. There have been some more changes made since then that might have made it a little weirder too (like showing "content type"), so it might make more sense now to just combine them all into one list.

    5 votes
    1. pseudolobster
      Link Parent
      Looks good to me. Seems to work at any width now. I do have that setting turned on. I don't recall enabling it. I do have tagging permissions. I don't mind the extra clutter of having all the tags...

      I increased the line-height on the tags a little now, which I think should help with the descenders getting cut off.

      Looks good to me. Seems to work at any width now.

      It only happens if you have the user setting to always show all tags on, which is non-default and very rare overall.

      I do have that setting turned on. I don't recall enabling it. I do have tagging permissions. I don't mind the extra clutter of having all the tags showing, though I suspect I might be in the minority there.

      Cheers, thanks for everything!

      4 votes
    2. unknown user
      Link Parent
      Add another vote to combine into one list. I also have all tags visible on posts, must've missed or otherwise forgotten about the hiding-tags change, and I thought seeing one tag embedded in...

      Add another vote to combine into one list. I also have all tags visible on posts, must've missed or otherwise forgotten about the hiding-tags change, and I thought seeing one tag embedded in between the content type and other metadata followed by all other tags on the next line was some weird HTML/CSS layout or formatting bug.

      3 votes
  2. [4]
    Comment deleted by author
    Link
    1. [3]
      pseudolobster
      Link Parent
      Ah, ok, that makes sense. I wasn't aware of that feature. From an end-user perspective though, it seems like this is a confusing way of doing it. Maybe all the tags should be in the same place,...

      tags after the group name are "important" tags

      Ah, ok, that makes sense. I wasn't aware of that feature. From an end-user perspective though, it seems like this is a confusing way of doing it. Maybe all the tags should be in the same place, but important ones are either at the front of the list or highlighted in some other way. It's a bit weird they're in two different places without any sort of differentiation.

      Thanks for looking into this!

      3 votes
      1. [3]
        Comment deleted by author
        Link Parent
        1. [2]
          pseudolobster
          Link Parent
          Still happening. DejaVu Sans, size 12, line height 14.4.

          Still happening. DejaVu Sans, size 12, line height 14.4.

          2 votes
          1. [2]
            Comment deleted by author
            Link Parent
            1. pseudolobster
              Link Parent
              Now that's interesting... I've tried resizing the width of my browser and it looks like there are specific widths it happens. Anything over ~1228px it seems to cut off, but under that it keeps...

              It seems to happen when resizing to specific widths

              Now that's interesting... I've tried resizing the width of my browser and it looks like there are specific widths it happens. Anything over ~1228px it seems to cut off, but under that it keeps switching back and forth.

              Here's my findings so far:

              >1228px q
              1228px g
              1184px q
              1124px g
              1002px q
              
              3 votes