9 votes

Minor bug: Can't collapse linked comments

Tags: bug, comments

The CSS selectors that determine whether or not to apply the display: none rule to comment text sections use the pseudo-class rule :not(:target). While this is great for keeping a comment in a non-collapsed state, it's a bit too effective as it prevents user-initiated collapsing of the comment. This can be problematic when you visit a direct link to a comment with an extensive reply tree beneath it and want to collapse it so that you can view the surrounding reply trees. As it stands, you can't do this without needing to either a) collapse the parent (prevents viewing sibling comments), b) collapse the children (requires collapsing potentially multiple child comments), or c) remove the fragment portion of the URL (requires reloading the page and possibly losing your place on the page).

Reproducing should be as simple as clicking Link in a comment's header, then trying to collapse the comment after being redirected.

2 comments

  1. cfabbro
    Link
    Sorry, I have been slacking on my ~tildes/Gitlab duties, so I only just now finally got around to adding this as an issue to gitlab: https://gitlab.com/tildes/tildes/-/issues/706

    Sorry, I have been slacking on my ~tildes/Gitlab duties, so I only just now finally got around to adding this as an issue to gitlab: https://gitlab.com/tildes/tildes/-/issues/706

    3 votes
  2. joplin
    Link
    I thought this was just some weirdness with my browser! I'm relieved to hear it's not just me who hits this.

    I thought this was just some weirdness with my browser! I'm relieved to hear it's not just me who hits this.

    2 votes