30
votes
I just submitted my first ever merge request!
After reviewing all the beginner friendly tags on the GitLab and figuring out easy answers the hard way, I finally made my first merge request for issue #700 to an open-source project! It isn't much, and probably took me 10x the amount of time it would take for someone who knows what they are doing, and it probably has some issues that needs to be worked out (although I tried to test as thoroughly as possible), I still submitted it. Even if it doesn't get accepted, I'm sure if someone wants to pick up my pieces, they can do so and build out this functionality in a better way.
I just wanted to share and put it out there that you don't have to be a master programmer to make contributions to this site))
Oh that's great, @Merry, thank you! You picked a relatively tricky thing as your first thing to try, since that involved needing to add an Alembic migration, a new template, and so on.
I'm pretty swamped with emails and invite requests and so on right now, but I'll try to review the code soon.
Take your time! It is a minor feature overall and likely needs some more work. Whenever you do have the time to review, let me know your feedback and I will be happy to make more changes.
Awesome job, @Merry. I just noticed the email notification for this merge request a few min ago. :)
I really like how you've made it user configurable too, to take into account people having different reading speeds.
Thank you, it was definitely a learning experience! Hopefully I can take on some more projects here and there to make the site a bit better now that I have gotten my toes wet.
I really want to work my way up to trying to implement the subscribing to tags issue but I think I need more smaller things to work on before attempting it. Web development is hard and this is stuff I have never done before, but it is incredibly gratifying when I get all the errors smoothed out and stuff starts working :)
I'm impressed! I put in a few comments, but it looks good! (Though I have very little experience with the Tildes codebase, so don't feel the need to take my advice.)
I put in one a few days ago with a bunch of simple CSS/template fixes, but I've been avoiding dealing with the python side because I'd probably break something... I might follow your lead and try something larger.
One issue that I'm considering is the auto light/dark theme switching, but that touches basically everything to some extent -- CSS, templates, intercooler stuff, the settings page, and database migrations (without a clear default...)